支持contextPath为空 #75
Open
支持contextPath为空 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const configClient = new NacosConfigClient({
serverAddr: '127.0.0.1:8848',
contextPath: '',
});
在使用NacosConfigClient时指定了contextPath但还是不生效，通过跟踪代码，发现在调http_agent中如果contenxPath为空，会再设置一次默认值，在创建NacosConfigClient时已经处理过一次（如果contextPath不存在则使用默认值'nacos')，所以我的理解这一步应该不需要了，也要考虑有些服务端进行改造时把contextPath去掉的情况。
|
许昆鹏 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
const configClient = new NacosConfigClient({
serverAddr: '127.0.0.1:8848',
contextPath: '',
});
在使用NacosConfigClient时指定了contextPath为空字符串但还是不生效，通过跟踪代码，发现在调http_agent中如果contenxPath为空，会再设置一次默认值，在new NacosConfigClient()时已经处理过一次（如果contextPath不存在则使用默认值'nacos')，所以我的理解这一步应该不需要了，也要考虑有些服务端进行改造时把contextPath去掉的情况。